r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

Since this is insta-stable, does this need an FCP?

Also, I'm not sure that the since is right.

I'm not really sure about how an FCP or the attribute works in this case. MOVBE itself was already stabilized, detection was omitted for whatever reason.

It might just be an oversight and not need FCP then. I suspect the since should still be the actual version, though. I think it can be the reviewer's call either way, but just felt it's worth mentioning.

I'd change the since to the current rustc version (1.67) since that is more accurate, even though movbe_target_feature was indeed stabilized in 1.34.

Otherwise LGTM. I'll FCP just in case but this should be pretty uncontroversial.

@rfcbot fcp merge

Unless of course, rfcbot doesn't work in this repo, in which case I'll just ping @rust-lang/libs-api to see if anyone has any objections.

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

• @Amanieu
• @BurntSushi
• @dtolnay
• @joshtriplett
• @m-ou-se
• @yaahc

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

I'm marking @yaahc's box because she has stepped down from T-libs-api after the point that this feature got proposed for FCP.

🔔 This is now entering its final comment period, as per the review above. 🔔

psst @Amanieu, I wasn't able to add the final-comment-period label, please do so.

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

psst @Amanieu, I wasn't able to add the finished-final-comment-period label, please do so.

Note that movbe_target_feature is still unstable in rustc, it should probably be stabilized there as well.